Repository navigation
Fix Aqara Roller Shade Driver E1 - #6898
Merged
Merged
Conversation
Expose `config/locked`, `config.reversed`, and `config/speed` (for window covering devices).
- Bug fix: `state.open` reported wrong value; - Add `config/reversed` and `config/speed`; - Deprecate `state/speed`; - Base `config/battery` and `config/charging` on 0xFCC0 attributes instead of on Xiaomi special attribute.
Replace `swversion` script with inline `eval`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve DDF for Aqara Roller Shade Driver E1 (aka
lumi.curtain.acn002):state.openshowed incorrect value. Note thatstate.openis true when the blind if fully opened, and false otherwise. Note thatstate.liftreports % closed, as per ZCL spec. Sostate.openis true only whenstate.liftis 0;config/batteryandconfig/chargingon 0xFCC0 attributes instead of on Xiaomi special attribute.config/reversedandconfig/speed;state/speed;= Remove
state.onandstate.bri, which have been deprecated for over three years now.I wanted to expose Child lock off as
config.locked, but it appears that, while the attribute can be changed alright, it doesn't do anything.To support this, I've added new resource items for
config/reversedandconfig/speed, and added API support forconfig/locked,config/reversed, andconfig/speedon a/lightsendpoint.