Skip to content

Fix Aqara Roller Shade Driver E1 - #6898

Merged
manup merged 6 commits into
dresden-elektronik:masterfrom
ebaauw:e1
Apr 16, 2023
Merged

manup merged 6 commits into
dresden-elektronik:masterfrom
ebaauw:e1

Conversation

@ebaauw

@ebaauw ebaauw commented Apr 14, 2023

Copy link
Copy Markdown
Collaborator

Improve DDF for Aqara Roller Shade Driver E1 (aka lumi.curtain.acn002):

  • Bug fix: state.open showed incorrect value. Note that state.open is true when the blind if fully opened, and false otherwise. Note that state.lift reports % closed, as per ZCL spec. So state.open is true only when state.lift is 0;
  • Base config/battery and config/charging on 0xFCC0 attributes instead of on Xiaomi special attribute.
  • Add config/reversed and config/speed;
  • Deprecate state/speed;
    = Remove state.on and state.bri, which have been deprecated for over three years now.

I wanted to expose Child lock off as config.locked, but it appears that, while the attribute can be changed alright, it doesn't do anything.

To support this, I've added new resource items for config/reversed and config/speed, and added API support for config/locked, config/reversed, and config/speed on a /lights endpoint.

ebaauw added 4 commits April 14, 2023 17:41
Expose `config/locked`, `config.reversed`, and `config/speed` (for window covering devices).
- Bug fix: `state.open` reported wrong value;
- Add `config/reversed` and `config/speed`;
- Deprecate `state/speed`;
- Base `config/battery` and `config/charging` on 0xFCC0 attributes instead of on Xiaomi special attribute.
@ebaauw ebaauw added Device Improvement Additional tag to attach to a existing issue. Fix labels Apr 14, 2023
@ebaauw
ebaauw requested review from SwoopX and manup April 14, 2023 16:35
ebaauw added 2 commits April 15, 2023 11:08
Replace `swversion` script with inline `eval`.
@manup manup added this to the v2.22.0-beta milestone Apr 16, 2023
@manup manup changed the title Bug fix Aqara Roller Shade Driver E1 Fix Aqara Roller Shade Driver E1 Apr 16, 2023
@manup
manup merged commit c8cae5d into dresden-elektronik:master Apr 16, 2023
@ebaauw
ebaauw deleted the e1 branch April 16, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Device Improvement Additional tag to attach to a existing issue. Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants