Skip to content

Conversation

@pimw1
Copy link
Contributor

@pimw1 pimw1 commented Jun 29, 2023

Corrected version. This DDF adds support for the black version of the Philips Hue Ensis.

Corrected version. This DDF adds support for the black version of the Philips Hue Ensis.
@pimw1 pimw1 changed the title Create light_zb3_C.json Add support for Philips Hue Ensis black edition within the light_zb3_C.json Jun 29, 2023
@pimw1 pimw1 changed the title Add support for Philips Hue Ensis black edition within the light_zb3_C.json Add DDF support for Philips Hue Ensis black edition within the light_zb3_C.json Jun 29, 2023
@BabaIsYou
Copy link
Contributor

BabaIsYou commented Jun 29, 2023

Can you just add a modified version of the DDF already into the manufacturer specific /philips subfolder rather than creating a new one on root /devices folder ?

@pimw1
Copy link
Contributor Author

pimw1 commented Jun 29, 2023

This is my first time ever to commit something on github. How do i do that?

@pimw1
Copy link
Contributor Author

pimw1 commented Jun 29, 2023

I've added a modified version of the DDF already into the manufacturer specific /philips subfolder

@pimw1
Copy link
Contributor Author

pimw1 commented Jun 29, 2023

...and the new file in the /devices folder is deleted. First time doing this, so learning on the go :)

@ebaauw ebaauw self-requested a review June 29, 2023 18:26
Copy link
Collaborator

@ebaauw ebaauw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this is looking good.

Changed the devices order to ascending order
@pimw1 pimw1 requested a review from ebaauw June 29, 2023 18:48
@pimw1
Copy link
Contributor Author

pimw1 commented Jun 29, 2023

I'm unable to understand why the workflow fails? It is refering to company folders not related to Philips. This PR is about a single json in the Philips folder.

Add support for the new Philips Hue Luster White and Color Ambiance, model identifier LCU001
@pimw1
Copy link
Contributor Author

pimw1 commented Jun 30, 2023

The new color variant of the Hue E14 Luster arrived. I've checked the attributes and based on this, added the model identifier to the DDF (addition of LCU001).
Tested on my installation, all working fine.

image
image
image
image

@pimw1 pimw1 changed the title Add DDF support for Philips Hue Ensis black edition within the light_zb3_C.json Add DDF support for Philips Hue Ensis black edition and Philips Hue Luster White and Color Ambiance within the light_zb3_C.json Jun 30, 2023
@ebaauw
Copy link
Collaborator

ebaauw commented Jul 1, 2023

Haven’t seen cluster 0xFC04 before. Does it stick when you re-read the Simple Descriptor?

What’s the Image Type for this light (in the OTA panel)?

@pimw1
Copy link
Contributor Author

pimw1 commented Jul 1, 2023

The 0xFC04 cluster sticks when re-reading the Simple Descriptor. The Image Type is 0x0000.
image

This cluster started to appear since firmware 1.104.2, and it shows for other Hue Lights as well since updating to firmware 1.104.2. For example, i see it for:

  • LCA006 (1100 lumen White and Color Ambiance E27 Bluetooth enabled). For this type, i do not see it for every light. Re-reading the Simple Descriptor does not change anything.
  • LCA008 (1600 lumen White and Color Ambiance E27 Bluetooth enabled)
  • LCE002 (470 lumen White and Color Ambiance E14 Bluetooth enabled). For this type, i do not see it for every light. Re-reading the Simple Descriptor does not change anything.
  • 929002376101 (the new Iris Bluetooth enabled)
  • 1746447P7 (The Hue Resonate shining both up and down)

The LCA001 (806lumen White and Color Ambiance E27 Bluetooth enabled) does not have this cluster. But i've only 1 of this type, so i can't say for sure.

What i can say for sure, is that this cluster appeared after the most recent firmware 1.104.2.

@pimw1
Copy link
Contributor Author

pimw1 commented Jul 1, 2023

After scrutinizing the results above, i see that the only lights not having the 0xFC04 cluster, are still on firmware 1.101.10. I'll update them now and report back the results.

@pimw1
Copy link
Contributor Author

pimw1 commented Jul 1, 2023

Everything is updated to 1.104.2, hereby the results:

  • LCA006 (1100 lumen White and Color Ambiance E27 Bluetooth enabled). For this type, i see the 0xFC04 cluster for 5-out-of-6 lights. For 1 light, i don't see the cluster. Instead i see cluster 0xFC02 " Hue Outlet" (which i don't see in the other 5 lights). See the printscreens:
    5 lights:
    image

1 light:
image
image

  • LCA008 (1600 lumen White and Color Ambiance E27 Bluetooth enabled): I have one light. For this light, the 0xFC04 cluster is visible.
  • LCE002 (470 lumen White and Color Ambiance E14 Bluetooth enabled). For this type, i have 5 lights. The 0xFC04 cluster is visible for all of them.
  • 929002376101 (the new Iris Bluetooth enabled). The 0xFC04 cluster is visible.
  • 1746447P7 (The Hue Resonate shining both up and down bluetooth enabled). The 0xFC04 cluster is visible.
  • The LCA001 (806lumen White and Color Ambiance E27 Bluetooth enabled): i've 1 light bulb. The 0xFC04 cluster is not visible, instead the FC02 cluster is visible:
    image

@ebaauw ebaauw added this to the v2.23.0-beta milestone Jul 7, 2023
@ebaauw ebaauw requested a review from manup July 7, 2023 12:20
@manup manup merged commit 56e9009 into dresden-elektronik:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants