Refactor gateway password code #7128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main goal was to dynamically load libcrypt with `dlopen`. The release build on Debian buster doesn't work Ubuntu Jammy, because it has a different version of the library. Further the code was separated from `DeRestPluginPrivate` into the `crypto/password.cpp` module not using Qt and be testable. TODO: Move away from libcrypt and use the scrypt functionality which we already have on each platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal was to dynamically load libcrypt with
dlopen. The release build on Debian buster doesn't work Ubuntu Jammy, because it has a different version of the library.Further the code was separated from
DeRestPluginPrivateinto thecrypto/password.cppmodule not using Qt and be testable.TODO: Move away from libcrypt and use the stronger scrypt functionality which we already have on each platform.