Repository navigation
DDF for IKEA RODRET Dimmer - #7230
Merged
Merged
Conversation
Rename _ZLL commissioning_ to _Touchlink Commissioning_, in line with ZCL v8 spec.
Add `RCapGroup`.
Add `RCapGroup`.
- Add `capabilities` to `sensors` resource. - Expose `productid` on sensors (where defined). Was already included in web socket notification.
Add `cap/group` to retrieve the group identifier(s) from the Touchlink Commissioning cluster.
Parse _Get Group Identifiers Response_ payload from _Touchlink Commissioning_ cluster.
Renamed to `rodret_dimmer.json`.
Legacy code still created `config.group` item and corresponding group on DDF exposed switches.
Collaborator
Author
|
Note |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this device looks like half a STYRBAR, it acts differently. It picks a group ID on reset, reports this through Touchpoint Commissioning, and creates a non-removable binding from the client On/Off cluster to this group. This means
config.groupshould match this group ID, and we need to create a binding of the client Level Control cluster to this group as well.Note that the device also sends an Add Group to the coordinator for the group it picked on reset.
Changes:
productidto show the product ID (Exxxx), sourced from 0x0000/0x000A.config/alert;config/battery:"fn": "zcl"to"fn": "zcl:attr"lreadwithrefresh.intervalof 86400;awake;state/buttonevent: add `awake;cap/group(to read the group from the Touchpoint Commissioning cluster andconfig/group(to create the group bindings). Through some C++ magic, the Get Group Identifier Response is used to populateconfig/group. While the API exposes this as read/write, changing it will not work, as the bindings to the Touchpoint Commissioning group cannot be removed.Generic
cap_group_item.json;touchlink_commissioning_cluster/1000_get_group_identifiers.jsto parse the Get Group Identifiers Response intocap/group.Legacy Code
binding.cpp: Bug fix: legacy code would still create aconfig/groupitem and correspondinggroupsresource on DDF managed devices.resource.cpp,resource.h: AddRCapGroup;rest_sensors.cpp: Exposecapabilitiesandproductidonsensorsresources that support these;general.xml: Rename ZLL Commissioning to Touchpoint Commissioning, in line with ZCL v8 spec.This PR was part of #7218.