DDF for Tradfri bulb GU10 CWS 345lm

[bluemoehre]

First time adding DDF by myself - I hope everything is fine =)

File is based on TRADFRI bulb E27 CWS 806lm since this bulb reports same OTAU image and looks identical in deCONZ.
So I just changed product & model.

Also added Device Request #7319 (dunno if that was required, but it helps with double checking)

[ebaauw]

File is based on TRADFRI bulb E27 CWS 806lm since this bulb reports same OTAU image and looks identical in deCONZ.

In that case, I would simply add the modelid to that DDF, cf. what I did for Hue lights. Of course, we'd need a better filename for the DDF.

[bluemoehre]

Of course, we'd need a better filename for the DDF.

Actually I was irritated a lot by the different DDF filenames and the mingling of 1:1 and 1:n configs. It's not very intuitive to find out if a device is already configured or not.
I can imagine that a base that can be extended, such as "Tradfri color light", "Tradfri white light" and "Tradfri controller", could reduce duplication, but on the other hand it increases complexity.
If it is guaranteed that the functionality is the same on all devices using the same image, we could group them according to the image ID.

For now I would go ahead and just keep it simple with a 1:1, due to its very clear, is easy to fix and all the redundancy should not be a huge deal with search/replace in the IDE.
This also corresponds to the docs:

The current implementation uses one directory per vendor and one file per product

But it is up to you guys what u prefer. Of course, I can also change the PR and add the model into the other file.

BTW:
Is there a way to test these changes without compiling the whole thing? I didn't find any documentation about the full workflow. Maybe I missed something?

[ebaauw]

Is there a way to test these changes without compiling the whole thing? I didn't find any documentation about the full workflow. Maybe I missed something?

Just copy the DDF to /usr/share/deCONZ/devices, or wherever deCONZ installs these, and restart deCONZ. Only new items in the API require changes in the C++ code and re-compilation.

[bluemoehre]

I added the JSON and now I can control the bulb completely via Phoscon - nice! So I would say DDF works.

Just let me know if I should change this PR to merge the DDFs into a single file.

[manup]

In that case, I would simply add the modelid to that DDF, cf. what I did for Hue lights. Of course, we'd need a better filename for the DDF.

Hi yes merging the manufacturer name / model id combo into the existing DDF should be fine.

[bluemoehre]

Hey @manup ,

sure I can merge the files + rename it to be more intuitive. But can I also create an array for the fields product (name) & description ? I was reading a while through everything and noticed we do not fulfil the project standards from the docs regarding those fields. Please correct me if I am wrong.

[manup]

The arrays are only needed (and supported) for modelid and manufacturername.
The product and descriptions fields are merely for the generated documentation to show some human readable text :)

[bluemoehre]

Okay - I thought it is that column showing the human readable name...

... but when I checked the Philips light bulbs, I found that it is actually the model ID in the product name column 🤔.

This is confusing and inconsistend vs. the detail page and should to be unified in one or another way.

I would recommend to show the human readable product name in the listing and the human readable product name + model id in the details page. But this is something that is related to Phoscon and is just an ad hoc idea without deeper checks.

[bluemoehre]

Files are merged & renamed.