Fix consumption reporting for Lidl SilverCrest (_TZ3000_j1v25l17) - #7621
Merged
Conversation
|
I think the lowercase of „Item.val“ is the only problem here |
Member
|
The former 420 interval is also better since it needs to be higher than the respective reporting interval. |
Contributor
Author
|
sorry, I think I screwed up my commit now... Not used to the usage of git in general... But it seems fine now (with 2 additional commits...)? |
Member
|
Multiple commit are fine, we mostly do squash merge the PRs so they get reduced to one commit :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've create a PR for this issue, @FlatTV provided the fix in #7603.
I've used a little bit different approach, because the missing ";" seemed as an issue compare to a different DDF of a Tuya Device.
Seems like the ";" was missing and also the "Item" was written Lowercase.
resolves #7603
old:
new: