Skip to content

DDF for ubisys S1(-R) corrected - #7630

Merged
manup merged 1 commit into
dresden-elektronik:masterfrom
Markkuuss:patch-ubisys-S1R
Mar 24, 2024
Merged

manup merged 1 commit into
dresden-elektronik:masterfrom
Markkuuss:patch-ubisys-S1R

Conversation

@Markkuuss

Copy link
Copy Markdown
Contributor

Currently, the light can only be switched on by push-button and can no longer be switched off if the S1(-R) sensor is configured to "mode": "momentary".

According to https://www.ubisys.de/wp-content/uploads/ubisys-s1-technical-reference.pdf, the values for "InputActions Attribute" are not correct. With the default values on page 29 for push-buttons (momentary), it works correctly again:

image

InputActions attributes for momentary corrected
@manup manup added the Fix label Feb 25, 2024

@SwoopX SwoopX left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either the bytes I've copied back in the days were incorrect or I fat-fingered here. Trusting the changes are currently in use by the requestor, as I don't have the device 🙂

@SwoopX SwoopX added this to the v2.26.2-beta milestone Mar 21, 2024
@manup
manup merged commit 330da9a into dresden-elektronik:master Mar 24, 2024
@torstenmarek

Copy link
Copy Markdown

I think this change broke my setup. When upgrading to a version that included this change, my S1s ended up as "momentary" switches, or maybe that had always been set to "momentary", but didn't behave like it. After changing them to "rocker" via the REST API, everything is back to normal

@Markkuuss

Copy link
Copy Markdown
Contributor Author

I think this change broke my setup. When upgrading to a version that included this change, my S1s ended up as "momentary" switches, or maybe that had always been set to "momentary", but didn't behave like it. After changing them to "rocker" via the REST API, everything is back to normal

As you can see in the code, only the value for momentary has changed. the value for the rocker setting has remained unchanged. Whether the S1(-R) is operated in momentary or rocker mode has always had to be set via the REST API. I don't really understand your problem, if you have installed a rocker switch, set it to rocker via the REST API and it works, then everything is fine. The standard for S1(-R) - even on delivery - is momentary push button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants