Fix loading of DDFs due constants.json race#7793
Merged
manup merged 1 commit intodresden-elektronik:masterfrom May 28, 2024
Merged
Fix loading of DDFs due constants.json race#7793manup merged 1 commit intodresden-elektronik:masterfrom
manup merged 1 commit intodresden-elektronik:masterfrom
Conversation
Stupid beginner mistake. The JSON files are read in arbitrary file system order. Which is ok except for the constants.json which need to be read first in order to determine if a DDF should be loaded.
This was
linked to
issues
May 28, 2024
Collaborator
|
Shouldn’t the relevant constants be included in the bundle? |
Collaborator
They are, the issue is for the not bundled DDF |
Collaborator
Makes you miss the MS-DOS days where you could sort the directory entries on disk. |
|
Hi all, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stupid beginner mistake. The JSON files are read in arbitrary file system order. Which is ok except for the
constants.jsonwhich need to be read first in order to determine if a DDF should be loaded.