TRADFRI bulb E27 WS opal 1000lm - intervals extended#8009
Merged
manup merged 3 commits intodresden-elektronik:masterfrom Nov 4, 2024
Merged
TRADFRI bulb E27 WS opal 1000lm - intervals extended#8009manup merged 3 commits intodresden-elektronik:masterfrom
manup merged 3 commits intodresden-elektronik:masterfrom
Conversation
Contributor
|
Hey @mattreim, thanks for your pull request! Tip Modified bundles can be downloaded here. DDB changesModified
ValidationTip Everything is fine ! 🕞 Updated for commit c7be419 |
bluemoehre
reviewed
Nov 1, 2024
| { | ||
| "at": "0x0000", | ||
| "dt": "0x10", | ||
| "min": 1, |
Contributor
There was a problem hiding this comment.
Having a minimum delay of 5s for reporting on/off (and any other state), seems bad to me. I would go with max 1s, since only with 0s you will get notified about each on/off event. I cannot imagine clicking a button in some interface and then wait 5s for it to turn off.
Actually I would like to ask if we need bindings at all.
Contributor
|
This pull request is now merged. The new DDB files have been uploaded to the store. DDB FilesModified
🕘 Updated for commit ac3e491 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary conversation #7591