Skip to content

Fix IKEA Somrig product type code - #8017

Merged
manup merged 1 commit into
dresden-elektronik:masterfrom
bluemoehre:fix-IKEA-Somrig-product-code
Nov 8, 2024
Merged

manup merged 1 commit into
dresden-elektronik:masterfrom
bluemoehre:fix-IKEA-Somrig-product-code

Conversation

@bluemoehre

Copy link
Copy Markdown
Contributor

See official manual (page 5)

@github-actions

github-actions Bot commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

Hey @bluemoehre, thanks for your pull request!

Tip

Modified bundles can be downloaded here.
Relative expire date

DDB changes

Modified

  • ikea/somrig_shortcut_button.json : Somrig shortcut button (E2213) ✔️

Validation

Tip

Everything is fine !

🕐 Updated for commit 1d08875

@ebaauw

ebaauw commented Nov 4, 2024

Copy link
Copy Markdown
Collaborator

Are you sure that's the only product type used for this device?

I know of IKEA products that use multiple different product types, e.g. the five-button TRADFRI remote controls uses both E1524 and E1810.

@bluemoehre

Copy link
Copy Markdown
Contributor Author

Since the code was introduced with the same commit for the RODRET (E2201) I believe it's a copy paste error.

@manup manup changed the title fix IKEA Somrig product type code Fix IKEA Somrig product type code Nov 8, 2024
@manup manup added the Fix label Nov 8, 2024
@manup manup added this to the v2.29.1-beta milestone Nov 8, 2024
@manup
manup merged commit 873a25c into dresden-elektronik:master Nov 8, 2024
@github-actions

github-actions Bot commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

This pull request is now merged. The new DDB files have been uploaded to the store.

DDB Files

Modified

  • ikea/somrig_shortcut_button.json : Somrig shortcut button (E2213) : with hash (d690a821c8)

🕜 Updated for commit 873a25c

@bluemoehre
bluemoehre deleted the fix-IKEA-Somrig-product-code branch November 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants