Fix DDF JSON format#8019
Conversation
|
Hey @bluemoehre, thanks for your pull request! Tip Modified bundles can be downloaded here. DDB changesModified
ValidationTip Everything is fine ! 🕤 Updated for commit 31fda63 |
|
Hey @manup , can you merge the cleanup by any chance on the fast lane, so we will have the same code format in all DDFs? |
|
Wow that's a bunch, good work 👍 |
|
This pull request is now merged. The new DDB files have been uploaded to the store. DDB FilesModified
🕖 Updated for commit c5cac4c |
Exactly - but first we have to agree on a setup. Unfortunately, I never received any feedback on this question in Discord. So let's stick with the standard format for now. Not perfect for all cases, but having everything the same is a step in the right direction. |
Currently there are multiple code format issues in some DDF JSON files.
This causes lots of linter warnings, when dealing with the project. Also it may lead to unnecessary complex reviews when fixing format issues on the fly while changing code.
So I fixed:
I did NOT fix:
… because this will cause line shifts and make the diff very hard to review. (I can place another PR when this one was merged.)
Note
No code contents were harmed in this PR 🐶