Fix light Websocket events#8191
Merged
Merged
Conversation
Similar treatment as in dresden-elektronik#8189 This PR will only emit Websocket events for the objects attr, state, config, etc. if the internal event for it originates such an item. It prevents extra events like config object when just an attr object should be send via Websocket. Clearing the push flags happens after lightToMap() was called to clear only items which fit the internal event suffix (and I prefer to let lightToMap() to not have this logic). The check group event is also emitted outside lightToMap() now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar treatment as in #8189
This PR will only emit Websocket events for the objects
attr,state,config, etc. if the internal event for it originates such an item. It prevents extra events likeconfigobject when just anattrobject should be send via Websocket.Clearing the push flags happens now after
lightToMap()is called to clear only items which fit the internal event suffix. I prefer to letlightToMap()to not have this logic. The check group event is also emitted outsidelightToMap()now.