Fix Ikea scenes with on/off going wild - #8197
Merged
Merged
Conversation
Issue: dresden-elektronik#8187 When a scene with on=false is recalled, we send a Off with effect command to Ikea lights since they otherwise won't turn off physically. There is also a StateChange added to ensure this works. Hoewever if a scene is then called with on=true, the StateChange *might* still be alive and turn the light off again. This can be seen in the issue. The PR clears state/on StateChange for Ikea lights when a scene is recalled preventing old state to be applied on a newer one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #8187
When a scene with
on=falseis recalled, we send a Off With Effect Command to Ikea lights since they otherwise won't turn off physically. There is also aStateChangeadded to ensure this works, which is usually a good thing.However if a scene is then called with
on=true, theStateChangemight still be alive and turn the light off again. This can be seen in the issue.The PR clears the
state/onStateChangefor Ikea lights when a scene is recalled preventing old state to be applied on a newer one.