Update general.xml file to use more data from LiXee device - #8228
Merged
Conversation
Update general.xml file to use more data from LiXee device
Collaborator
Contributor
Author
Collaborator
|
No, you haven't understand, it will stay with this change, but it will be visible only for user with a lixee. You can make a try, it will be just disabled for others users, because this attribute is only used on lixee. |
Contributor
Author
|
Okay, I didn't understand. |
Collaborator
|
Just a comment, all the PR is device specific, so no impact for others devices/users. |
Member
|
Hey, so the PR is ready to be merged? |
Contributor
Author
|
Yes, it is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Update general.xml file to use more data from LiXee device