DDF for Namron 8 button switch (4512772, 4512773) - #8240
Merged
Conversation
For 4512772, correct the capatalization of Manufacturer (Namron -> NAMRON) Create a seperate entry in button_maps.json to deal with dim down events from the 4512773 switch.
Contributor
Contributor
|
This pull request is now merged. The new DDB files have been uploaded to the store. DDB FilesModified
🕓 Updated for commit 4772a37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the Namron 8 button switches 4512772 and 4512773
I have successfully tested that this works for
4512773.The reason for the new block in
button_maps.jsonis that:The dim up buttons (1,3,4,5) send these commands:
When holding down: MOVE_WITH_ON_OFF (0x05)
When releasing: STOP_WITH_ON_OFF (0x07)
The dim down buttons (2,4,6,8) send these commands:
When holding down: MOVE (0x01)
When releasing: STOP (0x03)
What I don't know is if
4512772(or other devices) also need to use the new block inbutton_maps.jsonor not.(I only own the 4512773)
The capitalization of the manufacturer should be all-caps for both
4512772and4512773, but not for the other Namron devices.This is a fork of #7615 . See the discussion in that PR for more details.