Repository navigation
Fix battery reading of Sonoff water valve SWV-BSP - #8254
Merged
Merged
Conversation
2 tasks done
Contributor
manup
changed the title
manup
added
Fix
and removed
Device Improvement
Contributor
|
This pull request is now merged. The new DDB files have been uploaded to the store. DDB FilesModified
🕡 Updated for commit 4553533 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seem this device don't use attribute 0x0021 but 0x0020 for battery report.
See Sonoff SWV-BSP