Fix creation of invalid Unicast Bindings - #8288
Merged
Merged
Conversation
Seen on macOS somehow clang did not init all fields of the binding to zero when creation an object via `DDF_Binding result = {}`.
The u64 dstExtAddress wasn't initialized only the u16 dstGroup in the union. The ext address was some random stuff from memory.
The fix ensures all fields and dstExtAdress are zero. And the unicast dst address is filled with the actual coordinator mac address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen on macOS somehow clang did not init all fields of the binding to zero when creating an object via
DDF_Binding result = {}. Theu64 dstExtAddresswasn't initialized only theu16 dstGroupin the union. The ext address was some random stuff from memory.The fix ensures all fields including
dstExtAdressare zero. And the unicast destination address is filled with the actual coordinator mac address.Note: Invalid bindings from previous releases are automatically cleaned up and repaired by the
Devicestate machine.