Fix manufacturer specific cluster attributes with same ID as default attributes not being displayed/populated correctly #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manup
reviewed
Jul 29, 2024
Member
manup
left a comment
manup
left a comment
There was a problem hiding this comment.
Very welcome addition 🎉
I've added a few small remarks.
Member
|
I had this PR running since a few days, looks alright so 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although quite rare, probably one of the most annoying bugs in deconz GUI... until now. Whenever there were attribute IDs within the same cluster having no and a manufacturer specific code, the GUI wasn't able to display and update if correctly. This eventually led to a condition where devices couldn't be configured or only by manually editing
general.xmlfile.This PR finally fixes this. Was tested with a Philips motion sensor.