More reliable method of saving MIDI settings w/ PortMidi enabled

On macOS 10.13, Hatari w/ PortMidi support crashed for me when exiting the devices dialog because a check inside of strcpy() had failed.
dressupgeekout · Jan 6, 2022 · 06538ea · 06538ea
1 parent 6468198
commit 06538ea
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/gui-sdl/dlgDevice.c b/src/gui-sdl/dlgDevice.c
@@ -220,8 +220,8 @@ void Dialog_DeviceDlg(void)
 	ConfigureParams.Midi.bEnableMidi = (devicedlg[DEVDLG_MIDIENABLE].state & SG_SELECTED);
 #ifdef HAVE_PORTMIDI
 	assert(sizeof(dlgMidiInName) <= sizeof(ConfigureParams.Midi.sMidiInPortName));
-	strcpy(ConfigureParams.Midi.sMidiInPortName, midiInName ? midiInName : "Off");
+	snprintf(ConfigureParams.Midi.sMidiInPortName, sizeof(ConfigureParams.Midi.sMidiInPortName), "%s", midiInName ? midiInName : "Off");
 	assert(sizeof(dlgMidiOutName) <= sizeof(ConfigureParams.Midi.sMidiOutPortName));
-	strcpy(ConfigureParams.Midi.sMidiOutPortName, midiOutName ? midiOutName : "Off");
+	snprintf(ConfigureParams.Midi.sMidiOutPortName, sizeof(ConfigureParams.Midi.sMidiOutPortName), "%s", midiOutName ? midiOutName : "Off");
 #endif
 }