Added code to check for existence of html or text body when attachments ... #30

Merged
merged 1 commit into from Jan 16, 2013

4 participants

@mdesjardins

Hello,

This is only my second pull request, so I apologize if I'm not following proper etiquette!

I opened Issue #29 two days ago - the problem is that SES gets angry when you try to send an e-mail with an attachment and no other body text. Rather than do something doofy like create a default text body, I've tweaked the code to throw an ArgumentError with more descriptive text when someone tries to do this.

The code doesn't depend on ActionMailer, and there's an accompanying test. Let me know if you have any questions!

BTW - very nice work on this gem. It's been a lifesaver!

  • Mike
@drewblas
Owner

Thanks very much. I'm going to look at this and merge it in this weekend. Greatly appreciated!

@lulalala

+1 bump

@foohey

👍

@drewblas has a very long weekend ;)

@drewblas drewblas merged commit 3554901 into drewblas:master Jan 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment