[TS] LPS-118342 Prevent the passwordModifiedDate being later than the session creationTime #1134
Conversation
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test:sf |
|
ci:test:relevant |
|
Trigger the CI test before reviewing started. |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-118342 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#3857 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#8017 |
|
Hi @drewbrokke , Do you have any updates regarding the review? Thanks, |
hudakl
changed the title
|
Just started reviewing :) |
|
@hudakl Sorry about the delay, I'll review it now. |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
|
@hudakl LGTM 👍 |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#92452 |
Hi Drew,
I found that the issue occurs because after a succesful login the execution rans onto the PasswordModifiedFilter. In this, the _isPasswordModified returns true, after which the user is logged out. This happens because the passwordModifiedDate is updated after the session is created. That's what I try to avoid with this fix.
Could you please review my changes?
Thank you,
Laci