Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included flickity css file to Vue component #5

Merged
merged 2 commits into from Apr 5, 2018

Conversation

fishr01
Copy link
Contributor

@fishr01 fishr01 commented Feb 16, 2017

This includes the flickity modules css file into the Vue-flickity component stylesheets area

flickity.vue Outdated
@@ -103,3 +103,4 @@ export default {

};
</script>
<style src="./../flickity/dist/flickity.css"></style>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is the file path. I'm used to doing ~flickity/dist/flickity.css, the important part being the ~. I just want to make sure this doesn't break anyone's code because the file path is wrong. Can you ensure that it's working?

I am on board with including the css though I think. I haven't needed to use it yet but it's so lightweight that it shouldn't really matter.

@probil
Copy link

probil commented Apr 6, 2017

This works fine for me (and should work in general for everyone):

<style src="flickity/dist/flickity.css"></style>

But this two is not working:

<style src="~flickity/dist/flickity.css"></style>
<style src="./../flickity/dist/flickity.css"></style>

@homerjam
Copy link
Contributor

This also works for me, suggest changing PR to match?

<style src="flickity/dist/flickity.css"></style>

@drewjbartlett
Copy link
Owner

@homerjam Let me give it a go and then I could merge an updated PR :)

@homerjam
Copy link
Contributor

LGTM!

@homerjam
Copy link
Contributor

bump 😃

@drewjbartlett drewjbartlett merged commit a80f733 into drewjbartlett:master Apr 5, 2018
@schellenbergk
Copy link

was this tested in production? it does not seem to load flickity.css on my end in production and pageDots are not showing up (they are not styled, with height:0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants