Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null terminator and charset issues in heif implementation #370

Merged
merged 1 commit into from Oct 17, 2018

Conversation

payton
Copy link
Collaborator

@payton payton commented Oct 15, 2018

Closes #362

As per ISO documentation (in class comments), the modified fields are supposed to be null terminated and/or specify the UTF-8 charset.

@payton
Copy link
Collaborator Author

payton commented Oct 15, 2018

Can @lzzcg and/or @endy1106 validate these changes fix the first two points in #362? I was able to reproduce and fix the first issue, but I was unable to reproduce the second issue. I still made the changes because ISO documentation states the previous implementation was incorrect (not specifying Charset).

@payton
Copy link
Collaborator Author

payton commented Oct 15, 2018

@drewnoakes , once they can confirm their issues are resolved, feel free to merge this PR if you see fit.

Copy link
Owner

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Ran it on the one HEIC image we have from the linked issue.

Do you know where we can get some more HEIC images? There's a Nokia test set online but they're copyrighted.

@payton
Copy link
Collaborator Author

payton commented Oct 15, 2018

I was just looking into that... Since Apple has now made the switch from JPEG to HEIF, we should be able to get some good sample images that way. By default, I believe photos are converted to JPEG on iPhone (when exported), but there is an option to keep the original file. I don't have an iPhone, but I can ask around to try this out.

https://www.softwarert.com/transfer-photos-iphone-to-computer-heic-jpg/

@payton
Copy link
Collaborator Author

payton commented Oct 17, 2018

I'm going to go ahead and merge this as it seems to be an important fix for HEIF support.

@lzzcg and/or @endy1106 please comment on the issue if there is something that should be modified/added.

@payton payton merged commit 5124606 into drewnoakes:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants