Skip to content

setSubject is not setting charset #36

Closed
terjesb opened this Issue Sep 11, 2013 · 1 comment

2 participants

@terjesb
terjesb commented Sep 11, 2013

Norwegian characters (æøå) in the subject are shown as "?" in Gmail. When used in the body, they are shown okay. Sending to Gmail through SendGrid.

skjermbilde 2013-09-11 kl 16 29 39

                           {:from from
                            :to email
                            :subject "Test æøå"
                            :charset "utf-8"
                            :body [{:type "text/html; charset=utf-8"
                                    :content "Test æøå"}]}))))

I built a local version that adds charset to the setSubject call:

terjesb@00529b1

This fixes it for me. Not sure why all the other calls use charset and setSubject does not?

The existing tests still pass, but I haven't been able to make a test specifically for utf-8. Locally on OS X, the current tests seem to work with utf-8 as-is.

@drewr
Owner
drewr commented Nov 6, 2013

It's an oversight. Subject should definitely be covered. Sorry for taking so long to fix this, and thanks for the patch!

@drewr drewr added a commit that referenced this issue Nov 6, 2013
@drewr Apply charset to subject.
Closes #36.

Conflicts:
	test/postal/test/message.clj
705dc4f
@drewr drewr added a commit that closed this issue Nov 6, 2013
@drewr Apply charset to subject.
Closes #36.
4ad8f2e
@drewr drewr closed this in 4ad8f2e Nov 6, 2013
@drewr drewr added a commit that referenced this issue Oct 28, 2014
@drewr Apply charset to subject.
Closes #36.
525ee1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.