Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamify me #260

Merged
merged 61 commits into from Sep 20, 2021
Merged

Gamify me #260

merged 61 commits into from Sep 20, 2021

Conversation

loleg
Copy link
Collaborator

@loleg loleg commented Jul 21, 2021

This adds a long requested ability for admins to award special badges to projects, as well as an equally long awaited ability for all users to start an event if the site owners allow it. See #87 and https://github.com/dribdat/gamification for the inspiration.

  • Regular users can now start events with the option ALLOW_EVENT setting Make it easier to start an event #231
  • Admins can add a "booster post" to a project with a pre-defined list of award types Project distinctions #7
  • The timeline now features icons relevant to the type of update (see screenshot)
  • Boosters are also shown next to the project name, linked to the log, and in the user profile.
  • Admins can now delete posts from the project log, and add and remove team members*
  • Minor improvements have been made to resource recommendations Highlight and recommend projects #249
  • Slight reworking of the event header and footer layouts. The top navigation has been updated for usability.
  • The Post interface has been improved and made accessible from more locations in the app.
  • Top 10 issues are shown next to the GitHub widget, when available.
  • Our simple Search and API page is now linked in the navigation (woot!)
  • Refactoring, linting, and dependency upgrades.

gloriouspurpose

🚧 Developer notes

  • If auto upgrading of your instance does not complete, you may require a manual SQL entry to deploy to an existing site:
    ALTER TYPE activity_type ADD VALUE 'boost';
  • Note that non-admins can only propose, not yet edit or publish, events that they start (they are warned about this)
  • The new interface to removing (little x button) or adding (you have to enter the exact username) team members is very basic and admin-only for now:
    Screenshot from 2021-09-23 00-48-46

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #260 (2c62cb6) into main (42c0bdf) will decrease coverage by 0.51%.
The diff coverage is 34.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   46.24%   45.73%   -0.52%     
==========================================
  Files          29       29              
  Lines        2783     2882      +99     
==========================================
+ Hits         1287     1318      +31     
- Misses       1496     1564      +68     
Impacted Files Coverage Δ
dribdat/aggregation.py 10.85% <0.00%> (-0.09%) ⬇️
dribdat/user/constants.py 35.18% <6.25%> (-19.23%) ⬇️
dribdat/admin/views.py 33.95% <15.15%> (-0.85%) ⬇️
dribdat/user/models.py 57.35% <24.32%> (-1.79%) ⬇️
dribdat/public/project.py 23.89% <32.87%> (+4.23%) ⬆️
dribdat/public/views.py 44.02% <33.84%> (-8.86%) ⬇️
dribdat/admin/forms.py 100.00% <100.00%> (ø)
dribdat/public/forms.py 98.86% <100.00%> (+0.23%) ⬆️
dribdat/settings.py 98.64% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c0bdf...2c62cb6. Read the comment docs.

@loleg loleg temporarily deployed to dribdat-schoolofdata July 23, 2021 13:14 Inactive
@loleg loleg requested a review from gonzalocasas July 24, 2021 22:18
@loleg
Copy link
Collaborator Author

loleg commented Jul 24, 2021

Deployed and configured on meta for testing.

@gonzalocasas
Copy link
Collaborator

@loleg is the build fail something to worry about?

@loleg
Copy link
Collaborator Author

loleg commented Aug 25, 2021

I've managed to reproduce the error, which is a dependency issue. Thanks for pointing it out @gonzalocasas !

@loleg loleg added this to In progress in dribdat 0.6.0 Aug 29, 2021
@loleg loleg mentioned this pull request Sep 6, 2021
@loleg loleg temporarily deployed to dribdat-schoolofdata September 19, 2021 21:42 Inactive
@loleg
Copy link
Collaborator Author

loleg commented Sep 19, 2021

I've done a bit more final testing, tweaking - deployed to meta & schoolofdata for public testing.

@loleg loleg temporarily deployed to dribdat-schoolofdata September 20, 2021 05:37 Inactive
@loleg loleg moved this from In progress to Done in dribdat 0.6.0 Sep 20, 2021
@loleg loleg merged commit fc94374 into dribdat:main Sep 20, 2021
@loleg loleg deleted the gamifyme branch September 20, 2021 09:51
@loleg loleg removed this from Done in dribdat 0.6.0 Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants