Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

User comments & data import #267

Merged
merged 27 commits into from Oct 27, 2021
Merged

User comments & data import #267

merged 27 commits into from Oct 27, 2021

Conversation

loleg
Copy link
Collaborator

@loleg loleg commented Oct 1, 2021

We used dribdat to prepare data packages with a class of students at the Lucerne University of Applied Sciences and Arts. Part of this PR comes directly from their requests.

  • The ability to comment on a project - in the sense of a review - even when you are not part of the team. See note (1)
  • See related discussion in Voting on projects聽#87
  • Attaching a Data Package in the same way as images, by uploading directly to a project.
  • Import an event and its projects from a Data Package - as a template, or to mirror another site.
  • The above resolves Import and export project data聽#214
  • ALLOW_EVENTS enabled by default, so new (private) events can be started as a regular user.
  • Additional extensive refactoring and de-linting has been done in the API modules.
  • Minor usability fixes in the event and project views, and a revamp of the login screen.
  • The documentation has been updated and refactored, with detailed docs in the docs/ subfolder. See note (2)
  • There should be a video game hidden somewhere in the application 馃懢

Screenshot of a comment from a user above a log entry from a team member.

Notes 馃毀

(1) If you see errors in your dribs view, reapply the last two database migrations, or run these SQL commands:

ALTER TYPE activity_type ADD VALUE 'boost';
ALTER TYPE activity_type ADD VALUE 'review';

This will only affect upgrades from very recent dribdat installations.

(2) Apologies about breaking some documentation links. GitHub isn't going to help us here, but link checkers will.

@loleg loleg requested a review from RitzAnthony October 1, 2021 18:58
@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2021

Codecov Report

Merging #267 (f9da2fd) into main (66e50ec) will decrease coverage by 3.76%.
The diff coverage is 16.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   45.70%   41.93%   -3.77%     
==========================================
  Files          29       30       +1     
  Lines        2888     3238     +350     
==========================================
+ Hits         1320     1358      +38     
- Misses       1568     1880     +312     
Impacted Files Coverage 螖
dribdat/admin/views.py 33.79% <0.00%> (-0.16%) 猬囷笍
dribdat/apievents.py 15.15% <0.00%> (-3.04%) 猬囷笍
dribdat/app.py 83.33% <0.00%> (酶)
dribdat/user/constants.py 34.86% <0.00%> (-0.33%) 猬囷笍
dribdat/user/models.py 48.81% <8.42%> (-8.18%) 猬囷笍
dribdat/apifetch.py 15.59% <8.51%> (-0.98%) 猬囷笍
dribdat/aggregation.py 9.93% <9.52%> (-0.92%) 猬囷笍
dribdat/apipackage.py 10.15% <10.15%> (酶)
dribdat/public/api.py 29.67% <16.66%> (-2.88%) 猬囷笍
dribdat/apiutils.py 19.76% <19.35%> (+0.58%) 猬嗭笍
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 66e50ec...f9da2fd. Read the comment docs.

@loleg loleg changed the title DDA user comments User comments & data import Oct 16, 2021
@loleg
Copy link
Collaborator Author

loleg commented Oct 16, 2021

Deployed for testing at meta. E.g. see my comment on the Log at https://meta.dribdat.cc/project/41

@loleg loleg added this to Done in dribdat 0.6.0 Oct 16, 2021
@loleg loleg merged commit 5869d99 into dribdat:main Oct 27, 2021
@loleg loleg deleted the dda-user-comments branch October 27, 2021 10:13
@loleg loleg removed the request for review from RitzAnthony October 27, 2021 10:18
@loleg loleg removed this from Done in dribdat 0.6.0 Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import and export project data
2 participants