Fix: Auto-cancel trigger orders when position is closed (#923) #2039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #923 - Stop-loss orders are now automatically cancelled when the associated position is completely closed.
Problem
When users closed their positions, trigger orders (stop-loss/take-profit) remained active, creating a risk of:
Solution
cancel_trigger_orders_for_closed_position()function to handle automatic cancellationfulfill_perp_order()to detect when a position reaches zero and trigger cancellationChanges Made
New Function:
cancel_trigger_orders_for_closed_position()(lines 587-636)Modified Function:
fulfill_perp_order()(lines 2096-2112)Testing
Risk Mitigation
This fix prevents the following scenario: