Contacts, photos property doesn't work with null value

[cfjedimaster]

Given a contact instance, I'm not allowed to set the photos property to a new array to work with a contact that has no photos. So this,

        contact.photos = new Array();

doesn't validate in TypeScript. @mhartington thinks it may be an issue in the TS definition fie.

[cfjedimaster]

A bit more info - basically the issue is that the TS file knows it is an array, but doesn't accept that it may be null too.

[cfjedimaster]

So I removed readonly on the photos prop from the TS file and was able to get stuff working. :)

[keithdmoore]

You can't just set it to '[]' ?

[cfjedimaster]

Nope. You get an error. That goes away when readonly is removed.

[ihadeed]

This should be fixed by #635

[cfjedimaster]

Thanks. Any idea when this PR will get pulled in?

[ihadeed]

@cfjedimaster The next goal is 2.2.5 with some bug fixes, then I will merge that PR along with #422 and publish 2.3.0. So it shouldn't take long.

[cfjedimaster]

Ok, do you mind a dumb question? My code is doing this when a contact has no photos:

          var f = new ContactField('base64',s,true);

          contact.photos = [];
          contact.photos.push(f);

Will that work - specifically setting it to an empty array? I mean it works now with my hack (removing readonly), but your proper fix is a bit different.

[ihadeed]

@cfjedimaster Should be fixed now! Please update to v2.2.10 and let me know if you're still having any issues.

[cfjedimaster]

Thanks!