test: add initial test suite #523

Merged
merged 1 commit into from Sep 7, 2016

Projects

None yet

2 participants

@mattlewis92
Contributor
mattlewis92 commented Sep 2, 2016 edited

This is something I really missed when contributing as I couldn't verify any of my changes without building the dist file and drop it into an ionic project which isn't a fun DX 😄 The tests are pretty basic atm but the groundwork is there to expand them. I don't think there's a lot of point writing tests for specific plugins as you'd have to mock the cordova API, but there is definitely value in testing plugin.ts + probably ng1.ts

Let me know if you want me to change anything!

@ihadeed
Member
ihadeed commented Sep 7, 2016

Thansk @mattlewis92 .. great work!

@ihadeed ihadeed merged commit 1facde3 into driftyco:master Sep 7, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@mattlewis92 mattlewis92 deleted the mattlewis92:feat-tests branch Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment