Added swipe open menu from the edge of the screen #1570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional functionality where the slide menu open functionality can be set to only open the side menu when a swipe from the edge of the screen is done. This option can be set with <ion-side-menu-content drag-from-edge="false”></ion-side-menu-content>
MGMsystems
changed the title
|
I like this - however, I think it needs a bit more thought. I'll discuss it with @adamdbradley tomorrow. |
|
Seems like something we can/should put into a generic gesture detection system. Thoughts? |
|
I agree. But for now, I think this change is a good one. I pulled it in locally and cleaned up and tested it a bit, it works well. |
|
I could use this feature. Any ETA on the pull request? |
|
When will this be available in a build? |
|
It's available now in the nightly build, and will be in the next release. Check the Ionic project README for how to use the nightly build. |
|
Thanks for the info. Great job! Having a few issues using it with ion-slide-box, where should I discuss them? Here or the forum? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional functionality where the slide menu open functionality
can be set to only open the side menu when a swipe from the edge of the
screen is done. This option can be set with
<ion-side-menu-content drag-from-edge="true”></ion-side-menu-content>