Fix tests by upgrade karma and jasmine #1174

Merged
merged 1 commit into from Apr 1, 2016

Projects

None yet

2 participants

@pbakondy
Contributor

Updated packages

karma, karma-chrome-launcher, karma-coverage, karma-jasmine,
karma-phantomjs-launcher

New (necessary) packages

jasmine-core, phantomjs-prebuilt

Updated Jasmine commands (Jasmine 1.3 -> Jasmine 2)

spyOn(window.push, 'register').andCallFake ->
spyOn(window.push, 'register').and.callFake

expect(window.push.unregister.calls[0].args[2]).toBe(config) ->
expect(window.push.unregister.calls.argsFor(0)[2]).toBe(config)

spyOn($rootScope, '$broadcast').andCallThrough() ->
spyOn($rootScope, '$broadcast').and.callThrough()

@pbakondy pbakondy Fix tests by upgrade karma and jasmine
Updated packages:
karma, karma-chrome-launcher, karma-coverage, karma-jasmine,
karma-phantomjs-launcher

New (necessary) packages:
jasmine-core, phantomjs-prebuilt

Updated Jasmine commands (Jasmine 1.3 -> Jasmine 2):

spyOn(window.push, 'register').andCallFake ->
spyOn(window.push, 'register').and.callFake

expect(window.push.unregister.calls[0].args[2]).toBe(config) ->
expect(window.push.unregister.calls.argsFor(0)[2]).toBe(config)

spyOn($rootScope, '$broadcast').andCallThrough() ->
spyOn($rootScope, '$broadcast').and.callThrough()
9af3ab6
@gortok
Collaborator
gortok commented Apr 1, 2016

So this should resolve the broken build issue currently plaguing travis CI?

@gortok gortok merged commit f2b6d31 into driftyco:dev-next Apr 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pbakondy
Contributor
pbakondy commented Apr 1, 2016

Yes, this should :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment