Drinks
drinks

Organizations

@customink @styletiles @generalassembly-studio @unitedstates @nvite
Jul 14, 2016
@drinks
drinks created branch master at drinks/blackjack
Jul 14, 2016
drinks created repository drinks/blackjack
Jul 14, 2016
Jul 13, 2016
drinks commented on pull request msw3bb/blackjack#1
@drinks

I think @total might be superfluous here. Storing a computed value as local state can be useful when the calculation is expensive or should be allo…

Jul 13, 2016
drinks commented on pull request msw3bb/blackjack#1
@drinks

Nice work! I like the well-defined class oriented nature of this code, (and had fun playing!) I left a few comments just for illustration, but this…

Jul 13, 2016
drinks commented on pull request msw3bb/blackjack#1
@drinks

I alluded to methods like draw and hit elsewhere, but I think they'd be useful here as well.

Jul 13, 2016
drinks commented on pull request msw3bb/blackjack#1
@drinks

I think this method represents another mixing of concerns: the value of a card and the total value of a player's hand. It's true that whether an ac…

Jul 13, 2016
drinks commented on pull request msw3bb/blackjack#1
@drinks

I'd add here that you often hear talk of the 'law of demeter' in contexts such as this, which put simply states that any given class shouldn't know…

Jul 13, 2016
drinks commented on pull request msw3bb/blackjack#1
@drinks

A nice cleanup here would be to make the 'game' logic requirable. The unbound script code here will always execute at load time, regardless of whet…

Jul 13, 2016
drinks commented on pull request msw3bb/blackjack#1
@drinks

I'd probably define the initialize method first in my class, just fwiw

Jul 13, 2016
drinks commented on pull request msw3bb/blackjack#1
@drinks

Idiomatic ruby tends to use the functional iterators nowadays, so rather than shoveling inside a loop you can assign from the outside via map/flatten:

Jul 13, 2016
drinks commented on pull request msw3bb/blackjack#1
@drinks

I'd add that you can use the bang version when you're just assigning back, a la @game_deck.shuffle!

Jul 13, 2016
drinks commented on pull request msw3bb/blackjack#1
@drinks

Rather than manipulating the LOAD_PATH, ruby now provides a require_relative statement which would allow you to rewrite these like require_relative '…

Jun 19, 2016
drinks commented on issue drinks/sublime-initializr#2
@drinks

If I could get a gist of your settings (even if obfuscated) that would be great.

Jun 19, 2016
drinks commented on issue drinks/sublime-initializr#2
@drinks

Are you on Windows, by chance? #1 has a fix for this but it's a breaking change. I'll try to get it published out soon. On Sun, Jun 19, 2016 at 8:5…

Jun 2, 2016
drinks commented on pull request newrelic/rpm#243
@drinks

Thanks for the review, @kwugirl! What needs to happen to get this merged and a new release cut?

May 25, 2016
drinks opened pull request newrelic/rpm#243
@drinks
Allow oracle_enhanced adapter to obfuscate properly
1 commit with 3 additions and 2 deletions
May 25, 2016