Add basic git fsck command #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirnewton01
reviewed
Mar 21, 2019
| if err := verifyCommit(c, opts, CommitID(obj)); err != nil { | ||
| addErr(fmt.Errorf("error in commit %v: %v", obj, err)) | ||
| } | ||
| case "tree": |
There was a problem hiding this comment.
Are tags something that could show up in here too?
There was a problem hiding this comment.
I think so.. there's a few tag related tests which after the commit ones, so it'll probably come up then. First I need to make it past the t1450.15 test, I think, which keeps having a million other little unrelated things that need to be fixed/supported.
sirnewton01
reviewed
Mar 21, 2019
git/fsck.go
Outdated
| if strings.Count(pieces[1], ">") > 0 { | ||
| return fmt.Errorf("badName: invalid %v line - bad name", typ) | ||
| } | ||
| //fmt.Printf(`"%v" "%v" "%v"`+"\n", pieces[1], pieces[2], pieces[3]) |
There was a problem hiding this comment.
Is it worth logging this?
There was a problem hiding this comment.
I think it would be too verbose to log.. it was mostly just for figuring out which parts of the regex need to be greedy to pass the fsck tests.
sirnewton01
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a skeleton of the git fsck command. It passes the first 15 tests (looking for basic object corruption and verifying commits) from the official test suite.