Add possibility to parameterize S3 service URL#138
Merged
Conversation
* Add possibility to parameterize S3 service URL * add usage description into the docs * add rig for custom S3 servers * address PR review: add cods to rig, allow mock * forgot to commit tests/conftest.py :)
pjbull
changed the title
Contributor
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
======================================
Coverage 93.5% 93.5%
======================================
Files 21 21
Lines 1119 1119
======================================
Hits 1047 1047
Misses 72 72
|
jayqi
requested changes
Mar 26, 2021
Member
Author
|
@jayqi FYI, the tests don't actually pass. (The rig wasn't added to the list and so they weren't run). There are some failing tests that may actually be MinIO/S3 incompatibility, but I haven't gotten to the bottom of them yet. |
Member
Author
|
Also, changes you suggest make sense, feel free to make those and look at the failing tests. I'll check with you next time I have a chance to dig in to see if you uncovered anything |
pjbull
commented
Apr 2, 2021
Member
|
@pjbull I think this looks ready now if you have time to take a look. |
pjbull
commented
Apr 3, 2021
| if not getattr(rig, "is_custom_s3", False): | ||
| # Skip resetting the default client for custom S3 endpoint, but keep the other tests, | ||
| # since they're still useful. | ||
| rig.client_class._default_client = None |
Member
Author
There was a problem hiding this comment.
👏 I hadn't figured out why this one was failing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#137 added ability to specify the endpoint url for
S3PathThat work is accepted, and we need to now test if the configuration of the live tests for that scenario work from a non-fork branch.