Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build mypy errors #177

Merged
merged 2 commits into from Oct 7, 2021
Merged

Fix broken build mypy errors #177

merged 2 commits into from Oct 7, 2021

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Oct 6, 2021

  1. Updates AzureBlobClient._get_metadata return type per discussion in Failed build on master branch (tests #417) #172
  2. Explicitly silences mypy errors from azure.storage.blob.*. I decided we should implement this workaround because neither of these two following things seem like they're on track to getting fixed.

Closes #172

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #177 (90f3fe4) into master (8e4dcaf) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master    #177   +/-   ##
======================================
  Coverage    94.1%   94.1%           
======================================
  Files          21      21           
  Lines        1189    1189           
======================================
  Hits         1120    1120           
  Misses         69      69           
Impacted Files Coverage Δ
cloudpathlib/azure/azblobclient.py 94.6% <100.0%> (ø)

@jayqi jayqi requested a review from pjbull October 7, 2021 00:05
@pjbull pjbull merged commit cce6a2f into master Oct 7, 2021
@pjbull
Copy link
Member

pjbull commented Oct 7, 2021

Thanks @jayqi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed build on master branch (tests #417)
2 participants