Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't package tests #219

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Don't package tests #219

merged 2 commits into from
Apr 5, 2022

Conversation

psarka
Copy link
Contributor

@psarka psarka commented Apr 5, 2022

No description provided.

setup.py Outdated Show resolved Hide resolved
@jayqi jayqi linked an issue Apr 5, 2022 that may be closed by this pull request
@psarka
Copy link
Contributor Author

psarka commented Apr 5, 2022

Ugh, thanks for catching it.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #219 (28e5cba) into master (34c25df) will decrease coverage by 0.4%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #219     +/-   ##
========================================
- Coverage    94.7%   94.3%   -0.5%     
========================================
  Files          21      21             
  Lines        1248    1248             
========================================
- Hits         1183    1178      -5     
- Misses         65      70      +5     
Impacted Files Coverage Δ
cloudpathlib/s3/s3client.py 93.2% <0.0%> (-3.0%) ⬇️
cloudpathlib/gs/gsclient.py 92.3% <0.0%> (-2.0%) ⬇️

Copy link
Member

@jayqi jayqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@jayqi jayqi merged commit 965254b into drivendataorg:master Apr 5, 2022
@psarka psarka deleted the patch-1 branch April 6, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing cloudpathlib installs a package called tests
2 participants