Skip to content

Don't package tests - #219

Merged
jayqi merged 2 commits into
drivendataorg:masterfrom
psarka:patch-1
Apr 5, 2022
Merged

Don't package tests#219
jayqi merged 2 commits into
drivendataorg:masterfrom
psarka:patch-1

Conversation

@psarka

@psarka psarka commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread setup.py Outdated
@jayqi jayqi linked an issue Apr 5, 2022 that may be closed by this pull request
@psarka

psarka commented Apr 5, 2022

Copy link
Copy Markdown
Contributor Author

Ugh, thanks for catching it.

@codecov

codecov Bot commented Apr 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #219 (28e5cba) into master (34c25df) will decrease coverage by 0.4%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #219     +/-   ##
========================================
- Coverage    94.7%   94.3%   -0.5%     
========================================
  Files          21      21             
  Lines        1248    1248             
========================================
- Hits         1183    1178      -5     
- Misses         65      70      +5     
Impacted Files Coverage Δ
cloudpathlib/s3/s3client.py 93.2% <0.0%> (-3.0%) ⬇️
cloudpathlib/gs/gsclient.py 92.3% <0.0%> (-2.0%) ⬇️

@jayqi jayqi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@jayqi
jayqi merged commit 965254b into drivendataorg:master Apr 5, 2022
@psarka
psarka deleted the patch-1 branch April 6, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installing cloudpathlib installs a package called tests

2 participants