Fix intersphinx inventory #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
======================================
Coverage 94.8% 94.8%
======================================
Files 21 21
Lines 1323 1323
======================================
Hits 1255 1255
Misses 68 68 |
|
Looks good to me! I diffed the old and the new and see the class level ones mentioned in the issue showing up: |
|
@jayqi shall we cut a release with this one? |
pjbull
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing entries from Intersphinx inventory file by including root object in TOC for mkdocstrings. Closes #211.
The inventory file is available at
<base-url>/objects.invand can be parsed by sphobjinv.Some additional changes:
watchper mkdocstrings deprecation notepythontopython-legacyto recover old behavior. There are a few issues like Properties are rendered with parens mkdocstrings/python#9 that are not yet resolved in the new handler.