Skip to content

Skip docstrings if running with -OO#249

Merged
pjbull merged 2 commits into
masterfrom
238-import-fail
Aug 18, 2022
Merged

Skip docstrings if running with -OO#249
pjbull merged 2 commits into
masterfrom
238-import-fail

Conversation

@pjbull

@pjbull pjbull commented Aug 17, 2022

Copy link
Copy Markdown
Member

Manually tested and confirmed that PyPI version fails and this version succeeds.

Fixes #238

@github-actions

github-actions Bot commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

@codecov-commenter

codecov-commenter commented Aug 17, 2022

Copy link
Copy Markdown

Codecov Report

Merging #249 (3d9084d) into master (4cc0d33) will decrease coverage by 0.5%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #249     +/-   ##
========================================
- Coverage    95.0%   94.4%   -0.6%     
========================================
  Files          21      21             
  Lines        1324    1324             
========================================
- Hits         1258    1251      -7     
- Misses         66      73      +7     
Impacted Files Coverage Δ
cloudpathlib/cloudpath.py 93.5% <ø> (-0.5%) ⬇️
cloudpathlib/s3/s3client.py 92.9% <0.0%> (-2.7%) ⬇️
cloudpathlib/gs/gsclient.py 92.8% <0.0%> (-1.8%) ⬇️

@jayqi jayqi self-requested a review August 18, 2022 15:36
Comment thread cloudpathlib/cloudpath.py Outdated
@pjbull pjbull merged commit 796b695 into master Aug 18, 2022
@pjbull pjbull deleted the 238-import-fail branch August 18, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module fails to import when Python is ran with -OO

3 participants