Use abc.ABC as baseclass for AnyPath to fix issubclass behavior#251
Conversation
cda41c5 to
b9036df
Compare
|
Hm @chbehrens, looks like Ironically, it looks like the I'm ok with a |
|
I'm also fine with a I was also looking at python/mypy#5374 and it seems like it's possible this is addressed very recently in mypy (just 5 days ago) by python/mypy#13398. That PR was merged but is not released yet, so I think we'll potentially look at revisiting once the next release of mypy is published. |
|
Ok, I added the |
|
Thanks @chbehrens! You can ignore the failure for now, Github Actions is having an outage: I'll rerun these later once they stabilize the service |
|
Changes look good, thanks @chbehrens! I'm going to move this to a local branch to run the live server tests. |
#257) * Use abc.ABC as baseclass for AnyPath * add type ignore for ABC.register Co-authored-by: chbehrens <chbehrens@users.noreply.github.com>
Following @jayqi's suggestion in #247, this PR lets AnyPath inherit from abc.ABC and sets its subclasses via ABC.register. It also adds a test to check the bug filed in #246.
Fixes #246