Fix globbing top level buckets and#312
Merged
Merged
Conversation
Contributor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
======================================
Coverage 94.1% 94.1%
======================================
Files 21 21
Lines 1393 1395 +2
======================================
+ Hits 1312 1314 +2
Misses 81 81
|
jayqi
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#304 introduced a regression when globbing at the top level (
CloudPath("s3://bucket").glob("*")) where the bucket was duplicated in the paths that glob yielded (CloudPath("s3://bucket/bucket/file1.txt")is retruned), which was reported in #311. Additionally, #311 mentions thatCloudPath("s3://").glob("*")does not work as expected.This PR adds two fixes:
globto not duplicate the bucket at the top level.iterdirand.globworks within buckets.Additionally we add a regression test and update setup.py and changelog to make a patch release to fix this bug.