Speed up non recursive list_dir for google cloud storage#318
Merged
pjbull merged 5 commits intoFeb 15, 2023
Merged
Conversation
pjbull
requested changes
Feb 8, 2023
Member
|
Thanks @vlaminckaxel! Looks like a great speedup here. Let me know if you'll have a chance to tackle the code review comments, it would be great to get this in for our next release in a few days. |
Member
|
Merging this into a local branch to do code review tweaks and run live server tests. Thanks @vlaminckaxel! |
pjbull
added a commit
that referenced
this pull request
Feb 16, 2023
…cloud storage (#321) * Speed up non recursive list_dir for google cloud storage (#318) * use correct env vars for gs, azure bucket perf tests * speedup non recursive _list_dir for gs * linting * make gs mock compatible with delimiter * linting * Code review changes * revert dirs first --------- Co-authored-by: axel.vlaminck <axel.vlaminck@gmail.com>
Member
|
@vlaminckaxel this got shipped in |
Contributor
Author
Works like a charm 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-recursive implementation of list_dir for google cloud was slow.
The issue was already stated in the code that we just filtered out the top-level files and dirs out of al the blobs.
This is fixed by setting the delimiter='/' when listing a directory non-recursive.
Perf results
Before
After