Feat/pydantic serialization #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbull
requested changes
Nov 20, 2025
Member
pjbull
left a comment
pjbull
left a comment
There was a problem hiding this comment.
Looks good, pending tests + linting. Just a simplification for the docs change.
docs/docs/integrations.md
Outdated
|
|
||
| def serialize_as_http(path: S3Path) -> str: | ||
| """Convert S3Path to HTTP URL""" | ||
| return f"https://{path.bucket}.s3.amazonaws.com/{path.key}" |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Oh nice, updated!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 538-live-tests #538 +/- ##
================================================
- Coverage 94.0% 93.1% -0.9%
================================================
Files 28 28
Lines 2203 2203
================================================
- Hits 2071 2052 -19
- Misses 132 151 +19
🚀 New features to boost your workflow:
|
Member
|
Thanks! Moving to repo-local branch so we can run the live tests. |
pjbull
added a commit
that referenced
this pull request
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for pydantic serialization as uri.
Closes #537
Contributor checklist:
CONTRIBUTING.mdCloses #issueappears in the PR summary (e.g.,Closes #123).HISTORY.mdwith the issue that is addressed and the PR you are submitting. If the top section is not `## UNRELEASED``, then you need to add a new section to the top of the document for your change.