Skip to content

Conversation

@jayqi
Copy link
Member

@jayqi jayqi commented Oct 14, 2020

  • Fix a build issue with character encoding for Windows
  • Add macOS and Windows to CI, but skip tests on Windows

Opened #99 for the Windows test issues

@github-actions
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #98   +/-   ##
======================================
  Coverage    91.6%   91.6%           
======================================
  Files           9       9           
  Lines         672     672           
======================================
  Hits          616     616           
  Misses         56      56           

@jayqi jayqi requested a review from pjbull October 15, 2020 00:13
@jayqi jayqi mentioned this pull request Oct 15, 2020
@pjbull pjbull merged commit afeca69 into master Oct 15, 2020
@pjbull pjbull deleted the windows-fix branch October 15, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants