Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build bug #98

Merged
merged 3 commits into from Oct 15, 2020
Merged

Fix Windows build bug #98

merged 3 commits into from Oct 15, 2020

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Oct 14, 2020

  • Fix a build issue with character encoding for Windows
  • Add macOS and Windows to CI, but skip tests on Windows

Opened #99 for the Windows test issues

@github-actions
Copy link
Contributor

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #98   +/-   ##
======================================
  Coverage    91.6%   91.6%           
======================================
  Files           9       9           
  Lines         672     672           
======================================
  Hits          616     616           
  Misses         56      56           

@jayqi jayqi requested a review from pjbull October 15, 2020 00:13
@jayqi jayqi mentioned this pull request Oct 15, 2020
@pjbull pjbull merged commit afeca69 into master Oct 15, 2020
@pjbull pjbull deleted the windows-fix branch October 15, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants