New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: implement 'Detect and Select' component(s) #148

Closed
isms opened this Issue Oct 5, 2017 · 16 comments

Comments

Projects
None yet
9 participants
@isms
Copy link
Contributor

isms commented Oct 5, 2017

This issue will remain open until all the checkboxes are checked! PRs can reference this issue and will get credit even if the whole issue is not yet closed 馃憤

Note: split off from #110, interaction with imagery tracked in #179


Design doc reference here: http://concept-to-clinic.readthedocs.io/en/latest/design-doc.html#detect-and-select

Mock-up:

Expected Behavior

Users should be able to view predictions of nodule centroids and mark whether they are concerning or not:

  • List all available predicted candidate sites. Allow each to be selected to view details.
  • When a candidate is selected, show a detail view in an image viewer control. By default, show the slice containing the predicted centroid and a marker clearly indicating where the predicted centroid occurs.
  • Allow the user to zoom, pan, and navigate through slices in the image viewer.
  • Allow the user to window grayscale levels.
  • Allow the user to toggle the candidate centroid marker鈥檚 visibility.
  • Allow the user to mark any predicted candidate for further analysis.
  • Allow the user to navigate through the imagery freestyle and mark other locations which the models missed.
  • When the user has finished marking candidates, send all of this labeled data to the backend in the format specified above.

Possible Implementation

Basic Django templates were created for this in #88 - that is probably a good place to start.

Mocking data

Feel free to mock data for state if it is not yet implemented in the backend API, and feel free to POST to API endpoints that don't exist yet

@isms isms added this to the 1-mvp milestone Oct 5, 2017

@lmiller1990

This comment has been minimized.

Copy link

lmiller1990 commented Oct 6, 2017

Hi. I love what the project is looking to achieve and am a great supporter of the cause. I've done a lot of Vue.js, so I'm going to try and start building some of the UI related issues.

@isms

This comment has been minimized.

Copy link
Contributor

isms commented Oct 6, 2017

@lmiller1990 Glad to have you on board! 鉀碉笍

@lmiller1990

This comment has been minimized.

Copy link

lmiller1990 commented Oct 9, 2017

Thanks @isms . I'll see if I can get something done in the next few days, got everything up and running plus created some fake data.

Project is still early days - there aren't any models or much else in terms of data set up yet, should I just fake/make it up for now?

@stranger26

This comment has been minimized.

Copy link

stranger26 commented Oct 9, 2017

@lmiller1990 I think you should just fake it, at least that is from what I understand from the 'Mocking data' section.

@isms isms modified the milestone: 1-mvp Oct 10, 2017

@isms

This comment has been minimized.

Copy link
Contributor

isms commented Oct 11, 2017

@lmiller1990 @stranger26 New info on getting test data here - I also opened #153 to publicize this more.

@swederik

This comment has been minimized.

@louisgv

This comment has been minimized.

Copy link
Contributor

louisgv commented Oct 20, 2017

Is this issue being worked on? If not I will be looking at implementing it next week.

@antonow

This comment has been minimized.

Copy link
Contributor

antonow commented Oct 21, 2017

Where can we find some sample DICOM image data? I didn't see anything in the developer documentation. Should we just pull from the internet for now?

@louisgv

This comment has been minimized.

Copy link
Contributor

louisgv commented Oct 22, 2017

@antonow are you working on this component?

@isms

This comment has been minimized.

Copy link
Contributor

isms commented Oct 22, 2017

@antonow Check out the /tests/assets directory for example imagery.

@antonow

This comment has been minimized.

Copy link
Contributor

antonow commented Oct 23, 2017

@louisgv I was thinking about it, but no I am not currently working on this.

@louisgv

This comment has been minimized.

Copy link
Contributor

louisgv commented Oct 24, 2017

@antonow I will be tackling #182 then, since you probably got a plan to get this done. (I've not give it any thought yet :p )

@vessemer vessemer referenced this issue Oct 26, 2017

Merged

#179 DICOM image viewer #188

1 of 1 task complete

@isms isms modified the milestones: 1-mvp, 2-feature-building Oct 29, 2017

@vessemer vessemer referenced this issue Oct 31, 2017

Merged

#148 Manipulations with DICOM vue #197

1 of 1 task complete
@Serhiy-Shekhovtsov

This comment has been minimized.

Copy link
Contributor

Serhiy-Shekhovtsov commented Nov 7, 2017

I'm taking this issue, if nobody minds.

isms added a commit that referenced this issue Nov 13, 2017

@lamby

This comment has been minimized.

Copy link
Contributor

lamby commented Nov 23, 2017

Fixed in 093b06f

@lamby lamby closed this Nov 23, 2017

reubano added a commit that referenced this issue Nov 29, 2017

Detect and select: Attach nodule centroid marker to current slice (cl鈥
鈥ses #148)

* added method that returns candidates with DICOM slices file names

* updated NoduleMarker to show when marker position differs from current slice, added slice index to saving properties

* added sliceIndex property to DICOM viewer

* added slices loading and switching to CandidatesList component

@reubano reubano reopened this Nov 29, 2017

@lamby

This comment has been minimized.

Copy link
Contributor

lamby commented Dec 1, 2017

Merged in c4db12e: )

@Serhiy-Shekhovtsov

This comment has been minimized.

Copy link
Contributor

Serhiy-Shekhovtsov commented Dec 17, 2017

@lamby this can be closed, right?

@reubano reubano closed this Dec 18, 2017

louisgv added a commit to louisgv/concept-to-clinic that referenced this issue Jan 16, 2018

Detect and select: Attach nodule centroid marker to current slice (cl鈥
鈥ses drivendataorg#148)

* added method that returns candidates with DICOM slices file names

* updated NoduleMarker to show when marker position differs from current slice, added slice index to saving properties

* added sliceIndex property to DICOM viewer

* added slices loading and switching to CandidatesList component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment