New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DICOM viewer: errors in console and can't select slice #241

Closed
Serhiy-Shekhovtsov opened this Issue Nov 20, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@Serhiy-Shekhovtsov
Copy link
Contributor

Serhiy-Shekhovtsov commented Nov 20, 2017

When importing\browsing DICOM images the viewer is showing only once slice and doesn't allow scrolling. I can see following errors in console:

[Vue warn]: Error in callback for watcher "view.paths": "Error: updateImage: image has not been loaded yet"

found in

---> at src/components/open-image/OpenDICOM.vue
at src/components/open-image/ImageSeries.vue
at src/views/OpenImage.vue
at src/App.vue

And this one:

updateImage: image has not been loaded yet
at Object.exports.default (cornerstone.js?f051:309)
at Object.enable (cornerstoneTools.js?a9d4:1797)
at VueComponent.initCS (OpenDICOM.vue?67e0:112)
at VueComponent.boundFn [as initCS] (vue.esm.js?65d7:188)
at VueComponent.viewPaths (OpenDICOM.vue?67e0:49)
at Watcher.run (vue.esm.js?65d7:3175)
at flushSchedulerQueue (vue.esm.js?65d7:2927)
at Array.eval (vue.esm.js?65d7:1792)
at MessagePort.flushCallbacks (vue.esm.js?65d7:1713)

Steps to Reproduce

  1. Open home page
  2. Click Import
  3. Unfold until you find an image file
  4. Click on image file

Checklist before submitting

  • I have confirmed this using the officially supported Docker Compose setup using the local.yml configuration and ensured that I built the containers again and they reflect the most recent version of the project at the HEAD commit on the master branch
  • I have searched through the other currently open issues and am confident this is not a duplicate of an existing bug
  • I provided a minimal code snippet or list of steps that reproduces the bug.
  • I provided screenshots where appropriate
  • I filled out all the relevant sections of this template

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov changed the title DICOM viewer - errors in console and can't select slice DICOM viewer: errors in console and can't select slice Nov 20, 2017

@Serhiy-Shekhovtsov

This comment has been minimized.

Copy link
Contributor

Serhiy-Shekhovtsov commented Nov 20, 2017

I have created a task for all features the DICOM viewer should have - #240 and probably it will take some time to implement them. Till that time this bug can fixed separately.

@vessemer vessemer referenced this issue Nov 21, 2017

Merged

Allow to select slice #242

1 of 1 task complete
@swederik

This comment has been minimized.

Copy link

swederik commented Nov 22, 2017

Two issues I noticed in the code:

https://github.com/concept-to-clinic/concept-to-clinic/blob/54ce001d3fad2c18bd9c01dcf9b2907dda3a6448/interface/frontend/src/components/open-image/OpenDICOM.vue#L104-L112

  • You need to enable mouseWheelInput or your stackScrollWheel tool will not work:
cornerstoneTools.mouseWheelInput.enable(element)
  • You have both windowing and stack scrolling bound to the left mouse button, so it will probably act very strange

Hope that helps!

@lamby

This comment has been minimized.

Copy link
Contributor

lamby commented Nov 23, 2017

Merged in 4d867a0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment