Skip to content
This repository has been archived by the owner. It is now read-only.

Annotation: per-nodule notes should actually be PATCHed and saved #280

Closed
isms opened this issue Jan 5, 2018 · 5 comments
Closed

Annotation: per-nodule notes should actually be PATCHed and saved #280

isms opened this issue Jan 5, 2018 · 5 comments

Comments

@isms
Copy link
Contributor

@isms isms commented Jan 5, 2018

Expected Behavior

Manipulating these should be PATCHed to the backend and saved in the appropriate model instance:
image

Current Behavior

No-op

@Serhiy-Shekhovtsov
Copy link
Contributor

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov commented Jan 9, 2018

I'd like to take this one.

@Serhiy-Shekhovtsov
Copy link
Contributor

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov commented Jan 11, 2018

@isms, I can see that we are using PATCH for updating the candidate. Is there a reason for using POST here?

@isms
Copy link
Contributor Author

@isms isms commented Jan 11, 2018

@Serhiy-Shekhovtsov no, not at all, PATCH is the right verb 👍

@isms isms changed the title Annotation: per-nodule notes should actually be POSTed and saved Annotation: per-nodule notes should actually be PATCHed and saved Jan 11, 2018
@isms
Copy link
Contributor Author

@isms isms commented Jan 11, 2018

(issue updated to say PATCH - thanks Serhiy)

@Serhiy-Shekhovtsov
Copy link
Contributor

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov commented Jan 16, 2018

@isms the issue is solved in PR #286

@reubano reubano closed this Jan 16, 2018
@isms isms unassigned lamby Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants