New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation: per-nodule notes should actually be PATCHed and saved #280

Closed
isms opened this Issue Jan 5, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@isms
Copy link
Contributor

isms commented Jan 5, 2018

Expected Behavior

Manipulating these should be PATCHed to the backend and saved in the appropriate model instance:
image

Current Behavior

No-op

@Serhiy-Shekhovtsov

This comment has been minimized.

Copy link
Contributor

Serhiy-Shekhovtsov commented Jan 9, 2018

I'd like to take this one.

@Serhiy-Shekhovtsov

This comment has been minimized.

Copy link
Contributor

Serhiy-Shekhovtsov commented Jan 11, 2018

@isms, I can see that we are using PATCH for updating the candidate. Is there a reason for using POST here?

@isms

This comment has been minimized.

Copy link
Contributor

isms commented Jan 11, 2018

@Serhiy-Shekhovtsov no, not at all, PATCH is the right verb 👍

@isms isms changed the title Annotation: per-nodule notes should actually be POSTed and saved Annotation: per-nodule notes should actually be PATCHed and saved Jan 11, 2018

@isms

This comment has been minimized.

Copy link
Contributor

isms commented Jan 11, 2018

(issue updated to say PATCH - thanks Serhiy)

@Serhiy-Shekhovtsov

This comment has been minimized.

Copy link
Contributor

Serhiy-Shekhovtsov commented Jan 16, 2018

@isms the issue is solved in PR #286

@reubano reubano closed this Jan 16, 2018

@isms isms unassigned lamby Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment