New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#20 Document the Julian de Wit algorithm #108

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
3 participants
@WGierke
Copy link
Contributor

WGierke commented Sep 10, 2017

I added an initial documentation of the Julian de Wit algorithm. The algorithm output was ensembled with the results of the Daniel Hammack algorithm.

Reference to official issue

This pull request addresses #20

Motivation and Context

At some point we need to implement an algorithm that can segment the nodules and detect whether they are malicious or not. It makes sense to first evaluate the top 10 solutions for the Data Science Bowl 2017 regarding how performant they are and how easy it would be to use them in our application.

CLA

  • I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well

@WGierke WGierke force-pushed the WGierke:20_document_de_wit branch 2 times, most recently from c78e2d6 to b417e76 Sep 10, 2017

@WGierke

This comment has been minimized.

Copy link
Contributor

WGierke commented Sep 10, 2017

@timothyman Do you want to add any insights you talked about in PR #99 ? We'd highly appreciate it :)

@WGierke WGierke force-pushed the WGierke:20_document_de_wit branch from b417e76 to 8bca258 Sep 10, 2017

@timothyman

This comment has been minimized.

Copy link

timothyman commented Sep 10, 2017

@WGierke, sure. Unfortunately I wasn't joking when I said I needed a new harddisk before I can start to run the models and I'm out of town for the next 2 weeks without my DL box. So feel free to merge into master now.

On a first glance I noticed you probably missed some dependencies, scikit-image and lxml. Can you maybe take a look at my branch? I should have the complete list in the markdown file. Same location.

Also, I have seen that in order to get it running on Linux, you will have to remove and replace the dependency on ntpath with os.path in the step3 file. If I am not mistaken Python will handle this dependency automatically, so it should still work on Windows.

If I find anything else later I will create a new issue. Great writeups so far. Hope I can write one soon too.

@WGierke

This comment has been minimized.

Copy link
Contributor

WGierke commented Sep 11, 2017

@timothyman Thanks a lot :) It looks way nicer with such detailed dependency versions!
Oh I see :D I also didn't manage to run an algorithm so far because my internet connection always aborts before I finish downloading the whole training sets ...

@reubano

This comment has been minimized.

Copy link
Contributor

reubano commented Sep 11, 2017

Thanks @WGierke! LGTM. As you noted in #105, the tests recently broke. However, as this is just adding documentation, it should be fine to merge. Would you mind squashing to 1 commit now?

@WGierke WGierke force-pushed the WGierke:20_document_de_wit branch from ea7956b to 4a425da Sep 11, 2017

@WGierke

This comment has been minimized.

Copy link
Contributor

WGierke commented Sep 11, 2017

@reubano Alright, I squashed everything including the work of @timothyman into one commit.

@reubano reubano merged commit 7029895 into drivendataorg:master Sep 11, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
concept-to-clinic/cla @WGierke has signed the CLA.
Details

@reubano reubano referenced this pull request Sep 12, 2017

Closed

Feature: Implement identification algorithm #1

0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment