Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
#148 Manipulations with DICOM vue #197
Manipulations over DICOM such as
"cornerstone-core": " 0.13.0", "cornerstone-tools": " 0.10.0", "jquery": "^3.2.1"
I'd like to separate them from drawing features and made them part of
In this PR
Reference to official issue
This partially addresses #148
Well, I guess that for now, it's better to take
referenced this pull request
Nov 8, 2017
@lamby Jquery-Slim is still pretty sizable, according to their release note, it's "23.6k vs 30k.".
It would be best if we can use this pipeline: https://github.com/jquery/jquery/blob/master/README.md#how-to-build-your-own-jquery
And create an even slimmer version of jquery for
I haven't look closely at the module list of jquery-slim and whether if it has exactly what cornerstone need. But for now, I think we should be good to merge.
EDIT: so jquery-slim excludes
jQuery modules: https://github.com/jquery/jquery#modules
Nice work! Awesome to see Cornerstone added to this project!
Sorry about the issues with the README. For what it's worth, we are working towards dropping jQuery (though it will be slow to remove it from Cornerstone Tools since we are using it all over the place for events).