New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed nodule identification #213

Merged
merged 3 commits into from Nov 8, 2017

Conversation

Projects
None yet
2 participants
@Serhiy-Shekhovtsov
Copy link
Contributor

Serhiy-Shekhovtsov commented Nov 6, 2017

Fixed #191 (Nodule identification doesn't work)

Description

The problem was - passing image object to gtr123_model.predict method, when this method expects a path to a DICOM image.

How Has This Been Tested?

I checked that it starts with right input, but can't do the full run because of not enough memory error.

CLA

  • I have signed the CLA; if other committers are in the commit history, they have signed the CLA as well
@lamby

This comment has been minimized.

Copy link
Contributor

lamby commented Nov 7, 2017

Could you rebase your branch? I'm seeing a bunch of merge commits that don't seem necessary :)

@lamby
Copy link
Contributor

lamby left a comment

Could you add a bit of commentary (to the commit log, not here on Github) re. what this fixes specificially? Fixing stuff is great but I think we should document a little more to each other what the "fix" is so we can all learn!

@Serhiy-Shekhovtsov

This comment has been minimized.

Copy link
Contributor

Serhiy-Shekhovtsov commented Nov 7, 2017

@lamby, thanks for your feedback. I will check how to get rid of those merge commits and fix comments(by comments you mean commit messages, right?).

@Serhiy-Shekhovtsov Serhiy-Shekhovtsov force-pushed the Serhiy-Shekhovtsov:master branch from 648f810 to 65b9214 Nov 7, 2017

@Serhiy-Shekhovtsov

This comment has been minimized.

Copy link
Contributor

Serhiy-Shekhovtsov commented Nov 7, 2017

Rebased and fixed commits messages.

@lamby

This comment has been minimized.

Copy link
Contributor

lamby commented Nov 8, 2017

Great stuff, thanks!

@lamby lamby merged commit 9ba4610 into drivendataorg:master Nov 8, 2017

2 checks passed

concept-to-clinic/cla @Serhiy-Shekhovtsov has signed the CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reubano reubano referenced this pull request Nov 17, 2017

Open

Algorithms don't work across both dicom and luna scans #229

2 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment