Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implemented Imagery selection screen #236
According to documentation on this screen should in particular:
All these features has been implemented in this PR(frontend and backend).
Reference to official issue
Nov 19, 2017
referenced this pull request
Nov 20, 2017
@lamby my PR fits with requirements and easier for user: you can see images on the local system by default, click Preview and click Start new case.
From my point of view, those steps are redundant and don't match with requirements. Of course, @vessemer can still update his PR, but I can't see much sense in this. If points is an issue - I have no problem with sharing them between us.
@Serhiy-Shekhovtsov, in your PR I'm mainly concern with the
I think this is needed.. or, putting it another way, I could open another issue to do this separate to this. Let me know :)
Switching between cases is good idea. From my point of view, the following changes could improve the #233:
No need to show Import button and require user to click it
No need to require user to import image before starting a new case
Nor to show the redundant information. On the backend you can use
Accordion like behavior for files TreeView
Because user should see what file he is previewing now. In current version user can unfold multiple folders same time and it's not clear what DICOM is opened in the viewer at the moment. This is the reason I used
To clarify, it isn't really switching between cases it just that the system surely needs to be able to support multiple cases happening independently of each other.. I mean, otherwise we just have introduced a bunch of global variables / state that, well, that hopefully speaks for itself :)
Did you come to any conclusions on this on another ticket? :) Let me know and I'll "action" stuff ASAP.